Propertygrid node not updating with custom template

 I have the following templates defined for my property grid:

    <DataTemplate x:Key="PropertyGridReadOnlyCellTemplate">
        <TextBlock
            Text="{Binding Node.Value, Mode=OneWay}"
            Foreground="Black"
            Margin="-10,0"
            Padding="10,0"
            Background="{StaticResource ReadOnlyTextBlockBacground}"/>
    </DataTemplate>

    <DataTemplate x:Key="PropertyNameCellTemplate">
        <Border            
            Background="{DynamicResource LightBrush}"
            Padding="5,1.5,1.5,1.5"
            BorderBrush="SteelBlue"                                                           
            BorderThickness="0,0,1,0"            
            Margin="-6,0,0,-1">
            <TextBlock Text="{Binding Node.HumanName}" Margin="10,0,0,0" Foreground="Black" />    
        </Border>
    </DataTemplate>

 <Style x:Key="ReadOnlyPoppyGrid" TargetType="{x:Type ms:PropertyGrid}">
        <Setter Property="Template">
            <Setter.Value>
                <ControlTemplate TargetType="{x:Type ms:PropertyGrid}">
                    <Border Background="Transparent">
                        <DockPanel>
                            <!--Toolbar -->
                            <StackPanel                                        
                                DockPanel.Dock="Top"
                                Background="LightSteelBlue"
                                Visibility="{Binding IsToolBarVisible, RelativeSource={RelativeSource AncestorType={x:Type ms:PropertyGrid}},
                                Converter={StaticResource BooleanToVisibility}}">
                                <ms:ViewCommandsToolBar Target="{Binding BindingView, RelativeSource={RelativeSource AncestorType={x:Type ms:PropertyGrid}}}" />
                                <TextBlock
                                    HorizontalAlignment="Center"
                                    TextWrapping="Wrap"
                                    Padding="0,20"
                                    Visibility="{Binding BindingView.DefaultView.IsEmpty, RelativeSource={RelativeSource AncestorType={x:Type ms:PropertyGrid}}, Converter={StaticResource BooleanToVisibility}}">
                                    No properties match the search criteria.
                                </TextBlock>
                            </StackPanel>
                            <!-- Property grid-->
                            <ms:TreeListView Name="PART_Grid" ItemsSource="{TemplateBinding BindingView}" BorderThickness="0">
                                <ms:TreeListView.Columns>
                                    <GridViewColumnCollection>
                                        <GridViewColumn CellTemplate="{StaticResource PropertyNameCellTemplate}" Width="150"/>
                                        <GridViewColumn CellTemplate="{StaticResource PropertyGridReadOnlyCellTemplate}" />
                                    </GridViewColumnCollection>
                                </ms:TreeListView.Columns>
                                <ms:TreeListView.GroupStyle>
                                    <GroupStyle>
                                        <GroupStyle.ContainerStyle>
                                            <Style TargetType="{x:Type GroupItem}">
                                                <Setter Property="Template">
                                                    <Setter.Value>
                                                        <ControlTemplate>
                                                            <Border
                                                                Name="Bd"
                                                                BorderBrush="SteelBlue"                                                           
                                                                BorderThickness="1"                                                                
                                                                Background="{x:Static SystemColors.ControlLightLightBrush}"
                                                                Margin="0,5,1,5"
                                                                RenderTransformOrigin="0.5,0.5">
                                                                <StackPanel>
                                                                    <Border Name="TitleBd"
                                                                            BorderBrush="SteelBlue"
                                                                            BorderThickness="0,0,0,1"
                                                                            Padding="10,3,3,7"
                                                                            Background="{DynamicResource LightBrush}">
                                                                        <TextBlock                                                                        
                                                                            FontSize="11"
                                                                            FontWeight="Bold"
                                                                            Foreground="Black"
                                                                            Text="{Binding Name}" />
                                                                    </Border>
                                                                    <ItemsPresenter />
                                                                </StackPanel>
                                                                <Border.RenderTransform>
                                                                    <TransformGroup>
                                                                        <ScaleTransform x:Name="GroupScaler" ScaleX="1" ScaleY="1" />
                                                                        <RotateTransform x:Name="GroupRotater" Angle="0" />
                                                                    </TransformGroup>
                                                                </Border.RenderTransform>
                                                            </Border>
                                                        </ControlTemplate>
                                                    </Setter.Value>
                                                </Setter>
                                            </Style>
                                        </GroupStyle.ContainerStyle>
                                    </GroupStyle>
                                </ms:TreeListView.GroupStyle>
                            </ms:TreeListView>
                        </DockPanel>
                    </Border>
                </ControlTemplate>
            </Setter.Value>
        </Setter>
    </Style>

 The class bound to this property implements INotifyPropertyChanged.  However, when a property's source changes, the property grid does not immediately update.  If, I use the default template, that uses textboxes instead of textblocks for the Value of each property node, grid is updated when property source changes.

Any suggestions on how to resolve this using my templates.

Bind to Value rather than Node.Value.

Node should generally be used only for property metadata; its Value property should be avoided because it is not settable, is not strongly typed, and does not raise property change notifications.  (We realise the existence of a Node.Value property is confusing; in retrospect it should have been a GetValue method instead.)

Thanks for the response, but if I bind to Value rather than Node.Value, I property values are no longer displayed. 

Ivan, I made the following change

    <DataTemplate x:Key="PropertyGridReadOnlyCellTemplate">
        <TextBlock
            Text="{Binding Value, Mode=OneWay}"
            Foreground="Black"
            Margin="-10,0"
            Padding="10,0"
            Background="{StaticResource ReadOnlyTextBlockBacground}"/>
    </DataTemplate>

 as suggested but then property values are no longer displayed, which makes sense if the DataTemplate is being applied onto a Mindscape.WpfPropertyGrid.PropertyGridRow instance.

Oops, sorry, I misread your grid style and thought you were inserting this via the Editors collection rather than inserting it directly as the CellTemplate of the GridViewColumn.  You're right, my proposed "fix" won't work in that case, because it is indeed binding to a PropertyGridRow.

I don't think there's a way around this with your existing template.  You need to participate in the editor system in order for the grid to wire up all the notifications.  So I would suggest your second GridViewColumn delegate template selection to the grid's EditorSelector in the normal way.  You then plumb in your data template by setting it to be the editor for everything:

<!-- in property grid template -->

<GridViewColumn CellTemplateSelector="{Binding EditorSelector, RelativeSource={RelativeSource AncestorType={x:Type ms:PropertyGrid}}}" />

<!-- in property grid instantiation -->

<ms:PropertyGrid.Editors>
  <local:EverythingEditor EditorTemplate="{StaticResource PropertyGridReadOnlyCellTemplate}" />
</ms:PropertyGrid.Editors>

// in code

public class EverythingEditor : ObjectWrappingEditor {
  public override bool CanEdit(Node node) { return true; }
  protected override void SetContentTemplate(FrameworkElementFactory factory, Node node) {
    factory.SetValue(ContentControl.ContentTemplateProperty, EditorTemplate);
  }
}

(See http://www.mindscape.co.nz/blog/index.php/2008/04/30/smart-editor-declarations-in-the-wpf-property-grid/ for more info about this pattern.)

Your data template will now be receiving an ObjectWrapper<T> and can access its Value property, which does raise notifications and therefore enables the template to update as other code changes the value.

 Ivan, thanks again for the length response.  Did all you suggested but still no notification changes when a property 's source changes.  Here is my modified source:

<!-- instance -->

 <ms:PropertyGrid                  
                            IsToolBarVisible="False"                     
                            Style="{StaticResource ReadOnlyPoppyGrid}"
                            BorderThickness="1"                                
                            SelectedObject="{Binding Path=Beacon}" 
                             x:Name="alertPgrid"  >
                            <ms:PropertyGrid.Editors>
                                <wpfutil:EverythingEditor EditorTemplate="{StaticResource PropertyGridReadOnlyCellTemplate}" />
                            </ms:PropertyGrid.Editors>
                        </ms:PropertyGrid>

 <!-- grid style -->

    <Style x:Key="ReadOnlyPoppyGrid" TargetType="{x:Type ms:PropertyGrid}">
        <Setter Property="Template">
            <Setter.Value>
                <ControlTemplate TargetType="{x:Type ms:PropertyGrid}">
                    <Border Background="Transparent">
                        <DockPanel>
                            <!--Toolbar -->
                            <StackPanel                                        
                                DockPanel.Dock="Top"
                                Background="LightSteelBlue"
                                Visibility="{Binding IsToolBarVisible, RelativeSource={RelativeSource AncestorType={x:Type ms:PropertyGrid}},
                                Converter={StaticResource BooleanToVisibility}}">
                                <ms:ViewCommandsToolBar Target="{Binding BindingView, RelativeSource={RelativeSource AncestorType={x:Type ms:PropertyGrid}}}" />
                                <TextBlock
                                    HorizontalAlignment="Center"
                                    TextWrapping="Wrap"
                                    Padding="0,20"
                                    Visibility="{Binding BindingView.DefaultView.IsEmpty, RelativeSource={RelativeSource AncestorType={x:Type ms:PropertyGrid}}, Converter={StaticResource BooleanToVisibility}}">
                                    No properties match the search criteria.
                                </TextBlock>
                            </StackPanel>
                            <!-- Property grid-->
                            <ms:TreeListView Name="PART_Grid" ItemsSource="{TemplateBinding BindingView}" BorderThickness="0">
                                <ms:TreeListView.Columns>
                                    <GridViewColumnCollection>
                                        <GridViewColumn CellTemplate="{StaticResource PropertyNameCellTemplate}" Width="150"/>
                                       <GridViewColumn CellTemplateSelector="{Binding EditorSelector, RelativeSource={RelativeSource AncestorType={x:Type ms:PropertyGrid}}}" />
                                    </GridViewColumnCollection>
                                </ms:TreeListView.Columns>
                                <ms:TreeListView.GroupStyle>
                                    <GroupStyle>
                                        <GroupStyle.ContainerStyle>
                                            <Style TargetType="{x:Type GroupItem}">
                                                <Setter Property="Template">
                                                    <Setter.Value>
                                                        <ControlTemplate>
                                                            <Border
                                                                Name="Bd"
                                                                BorderBrush="SteelBlue"                                                           
                                                                BorderThickness="1"                                                                
                                                                Background="{x:Static SystemColors.ControlLightLightBrush}"
                                                                Margin="0,5,1,5"
                                                                RenderTransformOrigin="0.5,0.5">
                                                                <StackPanel>
                                                                    <Border Name="TitleBd"
                                                                            BorderBrush="SteelBlue"
                                                                            BorderThickness="0,0,0,1"
                                                                            Padding="10,3,3,7"
                                                                            Background="{DynamicResource LightBrush}">
                                                                        <TextBlock                                                                        
                                                                            FontSize="11"
                                                                            FontWeight="Bold"
                                                                            Foreground="Black"
                                                                            Text="{Binding Name}" />
                                                                    </Border>
                                                                    <ItemsPresenter />
                                                                </StackPanel>
                                                                <Border.RenderTransform>
                                                                    <TransformGroup>
                                                                        <ScaleTransform x:Name="GroupScaler" ScaleX="1" ScaleY="1" />
                                                                        <RotateTransform x:Name="GroupRotater" Angle="0" />
                                                                    </TransformGroup>
                                                                </Border.RenderTransform>
                                                            </Border>
                                                        </ControlTemplate>
                                                    </Setter.Value>
                                                </Setter>
                                            </Style>
                                        </GroupStyle.ContainerStyle>
                                    </GroupStyle>
                                </ms:TreeListView.GroupStyle>
                            </ms:TreeListView>
                        </DockPanel>
                    </Border>
                </ControlTemplate>
            </Setter.Value>
        </Setter>
    </Style>

<!-- data template -->

   <DataTemplate x:Key="PropertyGridReadOnlyCellTemplate">
        <TextBlock
            Text="{Binding Value, Mode=OneWay}"
            Foreground="Black"
            Margin="-5,0,0,0"
            Padding="10,0"
            Background="{StaticResource ReadOnlyTextBlockBacground}"/>
    </DataTemplate>

namespace ControlsLibrary.wpf.Utility
{
    public sealed class EverythingEditor : ObjectWrappingEditor
    {
        public override bool CanEdit(Node node) { return true; }
        protected override void SetContentTemplate(FrameworkElementFactory factory, Node node)
        {
            factory.SetValue(ContentControl.ContentTemplateProperty, EditorTemplate);
        }
    }
}

anything i could have missed?

Thanks again,

Klaus

Hmm, that looks okay.  Is it possible for you to create a small complete project that replicates the problem that you can post for us to look at?  You can attach a zip file via the Options tab or mail it to ivan @ the obvious domain name (please remove all binaries first).  This will make it a bit easier for us to figure out the problem.  Thanks!

 Ivan, someone changes are now being updated on the UI even though I have made absolutely no changes.  Strange but true.  So this issue can be considered resolved for now.  Thanks again for the help.