Descendent type [Adjustment] of type [Mindscape.LightSpeed.Entity`1[System.Int64]] is not discriminated.

Hello,

I'm getting the following exception when trying to create an entity, Adjustment, in a test. Adjustment doesn't participate in inheritance.

Mindscape.LightSpeed.LightSpeedException: Descendent type [Adjustment] of type [Mindscape.LightSpeed.Entity`1[System.Int64]] is not discriminated. 

The solution is rather large and I'm unable to send it. I tried to isolate it in a console application, but I'm unable to do so. Here is Adjustment:

[Table("Adjustments")]
public class Adjustment : Entity<long>
{
    #region Fields

    private int _amount;

    [ValidatePresence]
    [ValidateLength(0, 4096)]
    private string _description;

    private bool? _isTaxable;
    private long _currencyId;

    #pragma warning disable 649  // "Field is never assigned to" - LightSpeed assigns these fields internally
    private readonly int _lockVersion;
    private readonly DateTime _createdOn;
    private readonly DateTime _updatedOn;
    private readonly DateTime? _deletedOn;
    #pragma warning restore 649

    #endregion

    #region Field attribute and view names

    /// <summary>
    ///   Identifies the Amount entity attribute.
    /// </summary>
    public const string AmountField = "Amount";

    /// <summary>
    ///   Identifies the Description entity attribute.
    /// </summary>
    public const string DescriptionField = "Description";

    /// <summary>
    ///   Identifies the IsTaxable entity attribute.
    /// </summary>
    public const string IsTaxableField = "IsTaxable";

    /// <summary>
    ///   Identifies the CurrencyId entity attribute.
    /// </summary>
    public const string CurrencyIdField = "CurrencyId";

    #endregion

    #region Relationships

    [ReverseAssociation("Adjustments")]
    private readonly EntityHolder<Currency> _currency = new EntityHolder<Currency>();

    #endregion

    #region Properties

    public Currency Currency
    {
        get
        {
            return Get(_currency);
        }
        set
        {
            Set(_currency, value);
        }
    }

    public int Amount
    {
        get
        {
            return Get(ref _amount, "Amount");
        }
        set
        {
            Set(ref _amount, value, "Amount");
        }
    }

    public string Description
    {
        get
        {
            return Get(ref _description, "Description");
        }
        set
        {
            Set(ref _description, value, "Description");
        }
    }

    public bool? IsTaxable
    {
        get
        {
            return Get(ref _isTaxable, "IsTaxable");
        }
        set
        {
            Set(ref _isTaxable, value, "IsTaxable");
        }
    }

    /// <summary>
    ///   Gets or sets the ID for the <see cref="Currency" /> property.
    /// </summary>
    public long CurrencyId
    {
        get
        {
            return Get(ref _currencyId, "CurrencyId");
        }
        set
        {
            Set(ref _currencyId, value, "CurrencyId");
        }
    }

    /// <summary>
    ///   Gets the row version number for concurrency checking
    /// </summary>
    public int LockVersion
    {
        get
        {
            return _lockVersion;
        }
    }

    /// <summary>
    ///   Gets the time the entity was created
    /// </summary>
    public DateTime CreatedOn
    {
        get
        {
            return _createdOn;
        }
    }

    /// <summary>
    ///   Gets the time the entity was last updated
    /// </summary>
    public DateTime UpdatedOn
    {
        get
        {
            return _updatedOn;
        }
    }

    /// <summary>
    ///   Gets the time the entity was soft-deleted
    /// </summary>
    public DateTime? DeletedOn
    {
        get
        {
            return _deletedOn;
        }
    }

    #endregion
}

Currency is just another entity representing the currency in which the adjustment is made. I have several entities for which this exception is thrown. None of them participate in inheritance.

Any help would be appreciated.

Thanks, Werner

Hmm, this is a 'can't happen' error and without a repro it's hard to know what's causing it. The Adjustment class itself is not (necessarily) the problem -- the error is that internally we have mistaken Entity<long> for a 'real' base entity class, and Adjustment just happens to be the first descendant class we hit.

Do you have a source code licence? If so, if you build against the source code in Debug mode, you will get a Debug.Assert at a more useful location, and can look up the stack to see what type was being processed when the error occurred.

If not, could you post the stack trace of the exception and we will see if that sheds any light on the error -- if nothing else it will at least help to guide us if we need to make a diagnostic build for you. Thanks!

Hi Ivan,

No, I don't have the source code license. Unfortunately I have reverted back to an older build (4.0.811.18502) of LightSpeed. The issue doesn't reproduce with build 4.0.811.18502, however there are several defects that were fixed in newer builds.

I have a hard deadline for next week and have spent a majority of my time diagnosing LightSpeed issues rather than working on business related stuff. I'm a tad concerned about the quality of the nightly builds.

Thanks, Werner

Hi Ivan,

I looked through my older test runs and found a stacktrace that may be of use:

Mindscape.LightSpeed.LightSpeedException.ƒ(Exception , String , Object[] )
Mindscape.LightSpeed.LightSpeedException.ƒ(String , Object[] )
Mindscape.LightSpeed.Model.TypeModel.WalkHierachy(Type type, ICollection`1 typeModels, TypeModel parentTypeModel, DiscriminatorAttribute[] discriminatorAttributes, IEnumerable`1 additionalAssemblies)
Mindscape.LightSpeed.Model.TypeModel.LoadType(Type type, IList`1 typeModels)
Mindscape.LightSpeed.Model.TypeModel.GetTypeModel(Type type)
Mindscape.LightSpeed.Entity.Initialize()
Mindscape.LightSpeed.Entity..ctor(Boolean autoInitialize)
Mindscape.LightSpeed.Entity..ctor()
Mindscape.LightSpeed.Entity`1..ctor()
Workshare.Cloud.Data.PartyType..ctor() in S:\Cloud v1.2\src\Cloud.Data\PartyType.cs: line 64
Worlshare.Cloud.Data.Migrations.SeedDatabaseMigration.Up() in S:\Cloud v1.2\src\Cloud.Data.Migrations\SeedDatabaseMigration.cs: line 16
Mindscape.LightSpeed.Migrations.Migrator.Execute(Migration migration, Direction direction)
Mindscape.LightSpeed.Migrations.Migrator.MigrateUp(MigrationVersion currentVersion)
Mindscape.LightSpeed.Migrations.Migrator.Execute()

Here is the message for that exception:

Mindscape.LightSpeed.LightSpeedException: Mindscape.LightSpeed.LightSpeedException: Descendent type [PeopleOrganizations] of type [Mindscape.LightSpeed.Entity`1[System.Int64]] is not discriminated. 

Again, PeopleOrganizations do not participate in any inheritance, but joins People and Organizations in a many to many relationship. PeopleOrganizations has no relationship with PartyType and belongs to a different model.

I hope this helps

Thanks, Werner

PS I would like to suggest that LightSpeed logs to a trace source, so I can send you the logs in the future. Some issues I have found are rather hard to reproduce in isolation.

Thanks for the extra info. This error occurs if you have DiscriminatorAttribute on the base class of a hierarchy, i.e. a class that inherits directly from Entity<TId>. E.g.

[Discriminator(Attribute = "Kind", Value = 1)]
public class Person : Entity<int> { }

This attribute is not used on root classes because anything that doesn't match a derived class discriminator will be mapped to the base class anyway. Note that the class reported in the error message will NOT be the class with the unwanted DiscriminatorAttribute -- it will be some other class that gets picked up while we incorrectly try to process the root class discriminator.

Obviously however this should not cause an error and we will ship a fix in the next nightly build.

In the meantime, remove DiscriminatorAttribute from the base class of the PartyType hierarchy and you should be good to go.

Hi Ivan,

Thanks that suggestion worked on the lastest nightly build.

Werner