Error message: Descendent type [LogoImage] of type [Image] is not discriminated

Hi there,

I try to use the Mindscape.LightSpeed.MetaData.EntityInfo.FromType for a child class (LogoImage). That child class is a ConcreteTableInheritance from an abstract class (Image).

The call to EntityInfo.FromType() fails with the error message "Descendent type [LogoImage] of type [Image] is not discriminated". ConcreteTableInheritance doesn't need a discriminator - right? At least there is no option at the designer to enter in one.

As a repo use the model from http://www.mindscapehq.com/forums/thread/280804

Sörnt

You're right, concrete table inheritance is not discriminated. We'll look into this and hopefully get you a fix soon.

The following test passes for me using the "lsInsertOrderIssue.zip" model from the post you linked to:

[Test]
public void Fie()
{
  var ei = EntityInfo.FromType(typeof(LogoImage));
  Assert.AreEqual("LogoImage", ei.EntityType.Name);
}

I also tried it with our own suite of concrete table inheritance derived types, and it worked fine.

We have been making some ongoing changes to concrete table inheritance support so it is possible the problem has already been fixed. Please check whether the error still occurs with a current nightly build. If so, please provide us with a minimal repro (just the two entity types involved) and we will have another go!

I installed the current nightly (LightSpeed40Professional-20120326.msi)

That is the code I use (assembly is the assembly where is Model is located):

  List<Type> entityTypes = assembly.GetTypes()
                                    .Where(t => t.IsSubclassOf(typeof(Entity)))
                                    .ToList();
  foreach (Type entityType in entityTypes)
  {
    try
    {
      EntityInfo entityInfo = EntityInfo.FromType(entityType);
    }
    catch (Exception ex)
    {
      string msg = ex.Message;
    }
  }

Same error message. The exception is raised when the entityType is of "Image".

Okay, the error occurs when you call EntityInfo.FromType for the Image type, not the LogoImage type. This is because Image is an abstract base class in a concrete table inheritance hierarchy and does not provide its own EntityInfo. EntityInfo is meaningful only for realisable classes like LogoImage.

Filter out abstract classes and you will be good to go:

List<Type> entityTypes = assembly.GetTypes()
                                 .Where(t => t.IsSubclassOf(typeof(Entity)))
                                 .Where(t => !t.IsAbstract)
                                 .ToList();

Thanks for sorting that out! Consider to throw an suitable exception in that case. The error message right now is simple wrong.