DataGrid filtering problem

I've found that the filtering columns using the header button sometimes works and sometimes doesn't work for us. Using the debugger I believe I have figured out why it sometimes doesn't work, and I have come up with a small code change to ColumnFilter.cs that seems to solve the problem. I have observed that sometimes ColumnFilter.BuildDescription() gets called before the PropertyInfo property has been set on the column. When this happens BuildDescription() doesn't set -description. Later when ColumnFilter.Column-FilterChanged is called a null reference exception occurs (note: I am replacing underscores with hyphens because the underscores seem to not display correctly). I found that changing Column-FilterChanged seems to fix this problem.

private void Column_FilterChanged(object sender, EventArgs e)
{
    if (!_lock)
    {
        if (_description == null && _column.PropertyInfo != null)
        {
            BuildDescription();
        }
        if (_description != null)
        {
            _lock = true;
            _description.SetAs(_column.Filter);
            _lock = false;
        }
    }
}

Another solution would be to ensure that PropertyInfo is always initialized before the ColumnFilter is constructed. Possibly the order that the column properties are set affects this issue (though of course it shouldn't). I am setting the column properties in the following order: Header, DisplayMemberBinding, PropertyType, DisplayTemplate (and maybe a few others that are probably irrelevant here).

Peter

Hi Peter,

Thanks for mentioning this and even providing a fix. Your fix will be included in the next nightly build. Let me know if there are still problems here.

-Jason Fauchelle